]> git.baikalelectronics.ru Git - kernel.git/commit
mac80211: fix locking in ieee80211_sta_tear_down_BA_sessions
authorJohannes Berg <johannes.berg@intel.com>
Sat, 9 Dec 2017 20:10:10 +0000 (21:10 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 11 Dec 2017 09:50:00 +0000 (10:50 +0100)
commit1cca287168fcb6b8002510f579dabbf89c386e9d
treef72f4be5293d8b05fa095472e9a3b030775a542d
parent0e9531558831b3fd19af059a214fb89d0f38d4c7
mac80211: fix locking in ieee80211_sta_tear_down_BA_sessions

Due to overlap between
commit fdf58efa1c43 ("mac80211: Simplify locking in ieee80211_sta_tear_down_BA_sessions()")
and the way that Luca modified
commit d862397a3ecb ("mac80211: tear down RX aggregations first")
when sending it upstream from Intel's internal tree, we get
the following warning:

WARNING: CPU: 0 PID: 5472 at net/mac80211/agg-tx.c:315 ___ieee80211_stop_tx_ba_session+0x158/0x1f0

since there's no appropriate locking around the call to
___ieee80211_stop_tx_ba_session; Sara's original just had
a call to the locked __ieee80211_stop_tx_ba_session (one
less underscore) but it looks like Luca modified both of
the calls when fixing it up for upstream, leading to the
problem at hand.

Move the locking appropriately to fix this problem.

Reported-by: Kalle Valo <kvalo@codeaurora.org>
Reported-by: Pavel Machek <pavel@ucw.cz>
Tested-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/ht.c