]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 4 Jun 2013 10:49:07 +0000 (13:49 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Jun 2013 11:57:22 +0000 (13:57 +0200)
commit1cb4241c91ca9c50053029294d48e1f9c8e3aa30
treed6bb3515ad862a66897c2f5b1373fc3571416c60
parent9277fa4f437d8398c5494ee8a769d5ff043178a2
drm/i915: Assert dpll running in intel_crtc_load_lut() on pre-PCH platforms

Adding more context from Ville's reply to Rodrigo's question why we
need this:

"The spec says that on some hardware you need to PLL running before you
can poke at the palette registers. I didn't actually try to anger the
hardware so I'm not really sure what would happen otherwise, but IIRC
Jesse said something about a hard system hang..."

And generally documenting such ordering constraints with asserts is
Just Good.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
[danvet: Spruce up the commit message a lot.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c