]> git.baikalelectronics.ru Git - kernel.git/commit
hinic: Replace memcpy() with direct assignment
authorKees Cook <keescook@chromium.org>
Thu, 16 Jun 2022 05:23:12 +0000 (22:23 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 22 Jun 2022 18:04:32 +0000 (11:04 -0700)
commit1c1ff2a6132b2d040459b32ff34c28b57fa04958
tree50a9256d404487b053b2a4ea985a72903c740b81
parent7bbf9b1f5ca489f1607346bd8075a00aa67c2ab4
hinic: Replace memcpy() with direct assignment

Under CONFIG_FORTIFY_SOURCE=y and CONFIG_UBSAN_BOUNDS=y, Clang is bugged
here for calculating the size of the destination buffer (0x10 instead of
0x14). This copy is a fixed size (sizeof(struct fw_section_info_st)), with
the source and dest being struct fw_section_info_st, so the memcpy should
be safe, assuming the index is within bounds, which is UBSAN_BOUNDS's
responsibility to figure out.

Avoid the whole thing and just do a direct assignment. This results in
no change to the executable code.

[This is a duplicate of commit 2c0ab32b73cf ("hinic: Replace memcpy()
 with direct assignment") which was applied to net-next.]

Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Tom Rix <trix@redhat.com>
Cc: llvm@lists.linux.dev
Link: https://github.com/ClangBuiltLinux/linux/issues/1592
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org> # build
Link: https://lore.kernel.org/r/20220616052312.292861-1-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/huawei/hinic/hinic_devlink.c