]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: hv: Fix sleep while in non-sleep context when removing child devices from the bus
authorLong Li <longli@microsoft.com>
Mon, 30 Aug 2021 23:13:27 +0000 (16:13 -0700)
committerWei Liu <wei.liu@kernel.org>
Fri, 24 Sep 2021 09:34:29 +0000 (09:34 +0000)
commit1bef6600bf48638d4607ab8303a52c98a31e4937
tree7610b212a54973f9cb252b10e85a4aac75196653
parent3185df40ade12749370edb9983d680e6422cb1f2
PCI: hv: Fix sleep while in non-sleep context when removing child devices from the bus

In hv_pci_bus_exit, the code is holding a spinlock while calling
pci_destroy_slot(), which takes a mutex.

This is not safe for spinlock. Fix this by moving the children to be
deleted to a list on the stack, and removing them after spinlock is
released.

Fixes: 437e63ebd6ae ("PCI: hv: Fix a race condition when removing the device")
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Rob Herring <robh@kernel.org>
Cc: "Krzysztof WilczyƄski" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Michael Kelley <mikelley@microsoft.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/linux-hyperv/20210823152130.GA21501@kili/
Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Link: https://lore.kernel.org/r/1630365207-20616-1-git-send-email-longli@linuxonhyperv.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/pci/controller/pci-hyperv.c