]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: Fix uninitialized variable in xfs_reflink_reserve_cow_range()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 20 Oct 2016 04:41:48 +0000 (15:41 +1100)
committerDave Chinner <david@fromorbit.com>
Thu, 20 Oct 2016 04:41:48 +0000 (15:41 +1100)
commit1be7f9be0efa4e90547f50b8188f4e70710a1173
treef08149589bee3be8ee9ea4cc73a09ddf6a4d34c5
parent1d55a4bfd080ff4c6c96acfccfb7cdd2615ed6c2
xfs: Fix uninitialized variable in xfs_reflink_reserve_cow_range()

with gcc 4.1.2:

    fs/xfs/xfs_reflink.c: In function xfs_reflink_reserve_cow_range:
    fs/xfs/xfs_reflink.c:327: warning: error may be used uninitialized in this function

Indeed, if "count" is zero, the function will return an uninitialized
error value.

While "count" is unlikely to be zero, this function is called through
the public iomap API. Hence fix this by preinitializing error to zero.

Fixes: 2a06705cd5954030 ("xfs: create delalloc extents in CoW fork")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_reflink.c