]> git.baikalelectronics.ru Git - kernel.git/commit
vt: fix cursor when clearing the screen
authorMikulas Patocka <mpatocka@redhat.com>
Fri, 5 Apr 2019 00:53:28 +0000 (20:53 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2019 12:45:15 +0000 (14:45 +0200)
commit1bd1ad446b3c8aad48a6d258f60bc30b0ea0f538
tree6d6b26a4eb12c4211e8df114e0a93a9103efa952
parentd5beecfee260049ae48385d01e4c56255851050f
vt: fix cursor when clearing the screen

The patch ef35111ed3de ("vt: perform safe console erase in the right
order") introduced a bug. The conditional do_update_region() was
replaced by a call to update_region() that does contain the conditional
already, but with unwanted extra side effects such as restoring the cursor
drawing.

In order to reproduce the bug:
- use framebuffer console with the AMDGPU driver
- type "links" to start the console www browser
- press 'q' and space to exit links

Now the cursor will be permanently visible in the center of the
screen. It will stay there until something overwrites it.

The bug goes away if we change update_region() back to the conditional
do_update_region().

[ nico: reworded changelog ]

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Nicolas Pitre <nico@fluxnic.net>
Cc: stable@vger.kernel.org
Fixes: ef35111ed3de ("vt: perform safe console erase in the right order")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vt/vt.c