]> git.baikalelectronics.ru Git - kernel.git/commit
qed/qed_dev: guard against a possible division by zero
authorDaniil Tatianin <d-tatianin@yandex-team.ru>
Thu, 9 Mar 2023 20:15:56 +0000 (23:15 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2023 12:33:45 +0000 (13:33 +0100)
commit1aea5f2e3e7afdf68750af05e96ac1ab6625895d
treeef510e58c353d3e5a859b422a7226f4247d3f3e9
parentd92a5d24f9b418119cad5bc1b663eaec4430d7f0
qed/qed_dev: guard against a possible division by zero

[ Upstream commit 2773396e343926349c7982a2c3ce21f5ee31055d ]

Previously we would divide total_left_rate by zero if num_vports
happened to be 1 because non_requested_count is calculated as
num_vports - req_count. Guard against this by validating num_vports at
the beginning and returning an error otherwise.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: fc3edb2b22f4 ("qed: Add vport WFQ configuration APIs")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230309201556.191392-1-d-tatianin@yandex-team.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_dev.c