]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx4_en: Force CHECKSUM_NONE for short ethernet frames
authorSaeed Mahameed <saeedm@mellanox.com>
Mon, 11 Feb 2019 16:04:17 +0000 (18:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Feb 2019 17:26:21 +0000 (12:26 -0500)
commit1ad6e7d3da584b4dbd699f8d76f87feb68367308
treea67697092fbeeb7572439be103a21e2edfea1ad3
parent918c240c73d6cd2bcbbd870670f745722780a39a
net/mlx4_en: Force CHECKSUM_NONE for short ethernet frames

When an ethernet frame is padded to meet the minimum ethernet frame
size, the padding octets are not covered by the hardware checksum.
Fortunately the padding octets are usually zero's, which don't affect
checksum. However, it is not guaranteed. For example, switches might
choose to make other use of these octets.
This repeatedly causes kernel hardware checksum fault.

Prior to the cited commit below, skb checksum was forced to be
CHECKSUM_NONE when padding is detected. After it, we need to keep
skb->csum updated. However, fixing up CHECKSUM_COMPLETE requires to
verify and parse IP headers, it does not worth the effort as the packets
are so small that CHECKSUM_COMPLETE has no significant advantage.

Future work: when reporting checksum complete is not an option for
IP non-TCP/UDP packets, we can actually fallback to report checksum
unnecessary, by looking at cqe IPOK bit.

Fixes: 7943627623eb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends")
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_rx.c