]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: fix bogus warning in ext4_update_dx_flag()
authorJan Kara <jack@suse.cz>
Wed, 18 Nov 2020 15:30:32 +0000 (16:30 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 20 Nov 2020 03:41:10 +0000 (22:41 -0500)
commit1ad0d2652a1bf215c8bf599d0c9808a8250742c1
tree16f6f6ba6ef8d7c378c0c2e8b08eb73749cfbeb3
parente397c332ddf1f50e65a7f813a09de9a84972928d
ext4: fix bogus warning in ext4_update_dx_flag()

The idea of the warning in ext4_update_dx_flag() is that we should warn
when we are clearing EXT4_INODE_INDEX on a filesystem with metadata
checksums enabled since after clearing the flag, checksums for internal
htree nodes will become invalid. So there's no need to warn (or actually
do anything) when EXT4_INODE_INDEX is not set.

Link: https://lore.kernel.org/r/20201118153032.17281-1-jack@suse.cz
Fixes: 2e353f0b11e2 ("ext4: fix checksum errors with indexed dirs")
Reported-by: Eric Biggers <ebiggers@kernel.org>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/ext4.h