]> git.baikalelectronics.ru Git - kernel.git/commit
thermal: devfreq_cooling: use local ops instead of global ops
authorKant Fan <kant@allwinnertech.com>
Fri, 25 Mar 2022 07:30:30 +0000 (15:30 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 13 Apr 2022 14:49:43 +0000 (16:49 +0200)
commit1a6f7e7370a77f539ecf0a41d9b703517b7dcca8
treea6b1c5177df06e899e6b55690ef7079312b07e5a
parent99ff0e6a5b869839c022e3ce32fddd717970e118
thermal: devfreq_cooling: use local ops instead of global ops

Fix access illegal address problem in following condition:

There are multiple devfreq cooling devices in system, some of them has
EM model but others do not. Energy model ops such as state2power will
append to global devfreq_cooling_ops when the cooling device with
EM model is registered. It makes the cooling device without EM model
also use devfreq_cooling_ops after appending when registered later by
of_devfreq_cooling_register_power() or of_devfreq_cooling_register().

The IPA governor regards the cooling devices without EM model as a power
actor, because they also have energy model ops, and will access illegal
address at dfc->em_pd when execute cdev->ops->get_requested_power,
cdev->ops->state2power or cdev->ops->power2state.

Fixes: 1bcb0076bcb26 ("thermal: devfreq_cooling: remove old power model and use EM")
Cc: 5.13+ <stable@vger.kernel.org> # 5.13+
Signed-off-by: Kant Fan <kant@allwinnertech.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/devfreq_cooling.c