]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "rapidio: fix a NULL pointer dereference when create_workqueue() fails"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:11 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:32:17 +0000 (18:32 +0200)
commit1a50236ea28d2ffa648519fdee7f4e1ec04c19a9
tree047a22e6e5434bfac6a2bfe14cad38826d461bdd
parenta78e79773ea69f07ddc476c4e5af5fa9218086f3
Revert "rapidio: fix a NULL pointer dereference when create_workqueue() fails"

This reverts commit aba2cb2b5075b4d6f49b87888a5a16c1269ee4f1.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit has a memory leak on the error path here, it does
not clean up everything properly.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Fixes: aba2cb2b5075 ("rapidio: fix a NULL pointer dereference when create_workqueue() fails")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-45-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rapidio/rio_cm.c