]> git.baikalelectronics.ru Git - kernel.git/commit
io_uring: Fix XArray usage in io_uring_add_task_file
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 9 Oct 2020 12:49:52 +0000 (13:49 +0100)
committerJens Axboe <axboe@kernel.dk>
Fri, 9 Oct 2020 14:59:40 +0000 (08:59 -0600)
commit1a021052f7ec69e9f5ff6181c18e956e6e658b6c
tree4db44a68993f532093236a4e0692f3ce79241fce
parent2196dfba985ddf25d1ad7f6a1c327d8e6721938f
io_uring: Fix XArray usage in io_uring_add_task_file

The xas_store() wasn't paired with an xas_nomem() loop, so if it couldn't
allocate memory using GFP_NOWAIT, it would leak the reference to the file
descriptor.  Also the node pointed to by the xas could be freed between
the call to xas_load() under the rcu_read_lock() and the acquisition of
the xa_lock.

It's easier to just use the normal xa_load/xa_store interface here.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
[axboe: fix missing assign after alloc, cur_uring -> tctx rename]
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c