]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments
authorLyude Paul <lyude@redhat.com>
Wed, 23 Nov 2022 19:50:16 +0000 (14:50 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:40 +0000 (08:34 +0100)
commit188a5db12f59fc203b33d221f7e933d7b11511da
tree09301ba223d9ac625c7d1438f4941ec0bc92d3d5
parent75d112ad36b1d1fe1a238d4fd9ddf18a21d396de
drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments

commit ce121c9546e28221d4e0ae33c2161b9732205652 upstream.

Looks like I made a pretty big mistake here without noticing: it seems when
I moved the assignments of mst_state->pbn_div I completely missed the fact
that the reason for us calling drm_dp_mst_update_slots() earlier was to
account for the fact that we need to call this function using info from the
root MST connector, instead of just trying to do this from each MST
encoder's atomic check function. Otherwise, we end up filling out all of
DC's link information with zeroes.

So, let's restore that and hopefully fix this DSC regression.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2171
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Fixes: 94344e69a824 ("drm/display/dp_mst: Move all payload info into the atomic state")
Cc: stable@vger.kernel.org # 6.1
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Didier Raboud <odyx@debian.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c