]> git.baikalelectronics.ru Git - kernel.git/commit
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
authorTao Ma <boyu.mt@taobao.com>
Thu, 20 Sep 2012 15:35:38 +0000 (11:35 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 20 Sep 2012 15:35:38 +0000 (11:35 -0400)
commit18873a12a149134098ddaa8a3a95dd80b2b3673e
tree0d4b909ffb3fc1169cad66dd2e918fab78bb945b
parent47aa47da53d2ad7cac222200e9811f6ade838fe4
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()

The update_backups() function is used to backup all the metadata
blocks, so we should not take it for granted that 'data' is pointed to
a super block and use ext4_superblock_csum_set to calculate the
checksum there.  In case where the data is a group descriptor block,
it will corrupt the last group descriptor, and then e2fsck will
complain about it it.

As all the metadata checksums should already be OK when we do the
backup, remove the wrong ext4_superblock_csum_set and it should be
just fine.

Reported-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/resize.c