]> git.baikalelectronics.ru Git - kernel.git/commit
drm/komeda: Handle NULL pointer access code path in error case
authorCarsten Haitzler <carsten.haitzler@arm.com>
Fri, 27 Nov 2020 11:00:54 +0000 (11:00 +0000)
committerLiviu Dudau <liviu.dudau@arm.com>
Fri, 18 Dec 2020 16:35:53 +0000 (16:35 +0000)
commit17ed3c4432857b1ab532ec49a81735958bb27673
tree869eb17ca6547efa7da1082cd4d6bc7843b8f995
parentf29471ae29b34b5dd1521054dffe5ab8dbeec636
drm/komeda: Handle NULL pointer access code path in error case

komeda_component_get_old_state() technically can return a NULL
pointer. komeda_compiz_set_input() even warns when this happens, but
then proceeeds to use that NULL pointer to compare memory content there
agains the new state to see if it changed. In this case, it's better to
assume that the input changed as there is no old state to compare
against and thus assume the changes happen anyway.

Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
[Applied small spelling fixes and fix suggested by Steven Price]
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201127110054.133686-1-carsten.haitzler@foss.arm.com
drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c