]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: Fix uninintialized error return
authorColin Ian King <colin.king@canonical.com>
Mon, 29 Jun 2015 16:10:22 +0000 (17:10 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 29 Jun 2015 17:08:31 +0000 (19:08 +0200)
commit178bc1b9f9b788614ae569de033221487eb84e2a
treeedb8d032ea6c474cbb78860bb3937f7b57244df2
parent39c5168f29fa7b2cb73ae1fb1caac23349cb16a3
ALSA: Fix uninintialized error return

Static analysis with cppcheck found the following error:
  [sound/core/init.c:118]: (error) Uninitialized variable: err

..this was introduced by commit b8d096132dd7cc078bfb33c4554197e55fedc11b
("ALSA: info: Register proc entries recursively, too") where the call
to snd_info_card_register was removed and no longer setting the error
return in err.  When snd_info_create_card_entry fails to allocate a
an entry, the error path exits with garbage in err.  Fix is to return
-ENOMEM if entry fails to be allocated.

Fixes: b8d096132d ("ALSA: info: Register proc entries recursively, too")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/init.c