]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: cs46xx: Fix missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 5 Jul 2022 15:23:36 +0000 (17:23 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 5 Jul 2022 15:24:05 +0000 (17:24 +0200)
commit16bd22df12eba5bea30648f0a0f6c0be19f660be
tree38c888a9d597fa2c465fbf009448e9ae9898f02e
parentc8331de3785fb5ed01404615b0822140316ae25f
ALSA: cs46xx: Fix missing snd_card_free() call at probe error

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

This patch fixes it by calling snd_card_free() manually on the error
from the probe callback.

Fixes: 2eacf4eb6962 ("ALSA: cs46xx: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Reported-and-tested-by: Jan Engelhardt <jengelh@inai.de>
Link: https://lore.kernel.org/r/p2p1s96o-746-74p4-s95-61qo1p7782pn@vanv.qr
Link: https://lore.kernel.org/r/20220705152336.350-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/cs46xx/cs46xx.c