]> git.baikalelectronics.ru Git - kernel.git/commit
usb: typec: Fix unchecked return value
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 18 Mar 2019 21:18:30 +0000 (16:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Mar 2019 13:57:31 +0000 (14:57 +0100)
commit15e79f2aecc43af77f1d56a073887608bccac7c9
treefb5230b97ff8b7ecdca46e87cc8fca452d8df878
parent805099b2fb57eba3d69bc38aeb447dfe76b0ebb9
usb: typec: Fix unchecked return value

Currently there is no check on platform_get_irq() return value
in case it fails, hence never actually reporting any errors and
causing unexpected behavior when using such value as argument
for function regmap_irq_get_virq().

Fix this by adding a proper check, a message error and return
*irq* in case platform_get_irq() fails.

Addresses-Coverity-ID: 1443899 ("Improper use of negative value")
Fixes: 838d94f602e4 ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/wcove.c