]> git.baikalelectronics.ru Git - kernel.git/commit
perf/x86/intel/cqm: Check cqm/mbm enabled state in event init
authorJiri Olsa <jolsa@kernel.org>
Mon, 5 Sep 2016 15:30:07 +0000 (17:30 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 6 Sep 2016 08:42:12 +0000 (10:42 +0200)
commit15d27d9a8ad00d65a10be56007fe43f405b60a52
tree6a33936b56e9a3d706ad7b0c3344c48a83f9b728
parenta635a17ce1682ee68a9c7c413719a9456abefd5b
perf/x86/intel/cqm: Check cqm/mbm enabled state in event init

Yanqiu Zhang reported kernel panic when using mbm event
on system where CQM is detected but without mbm event
support, like with perf:

  # perf stat -e 'intel_cqm/event=3/' -a

  BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
  IP: [<ffffffff8100d64c>] update_sample+0xbc/0xe0
  ...
   <IRQ>
   [<ffffffff8100d688>] __intel_mbm_event_init+0x18/0x20
   [<ffffffff81113d6b>] flush_smp_call_function_queue+0x7b/0x160
   [<ffffffff81114853>] generic_smp_call_function_single_interrupt+0x13/0x60
   [<ffffffff81052017>] smp_call_function_interrupt+0x27/0x40
   [<ffffffff816fb06c>] call_function_interrupt+0x8c/0xa0
  ...

The reason is that we currently allow to init mbm event
even if mbm support is not detected.  Adding checks for
both cqm and mbm events and support into cqm's event_init.

Fixes: 52c5985585a8 ("perf/x86/mbm: Add Intel Memory B/W Monitoring enumeration and init")
Reported-by: Yanqiu Zhang <yanqzhan@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1473089407-21857-1-git-send-email-jolsa@kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/events/intel/cqm.c