]> git.baikalelectronics.ru Git - kernel.git/commit
drm/ttm/nouveau: don't call tt destroy callback on alloc failure.
authorDave Airlie <airlied@redhat.com>
Tue, 28 Jul 2020 04:17:36 +0000 (14:17 +1000)
committerDave Airlie <airlied@redhat.com>
Wed, 29 Jul 2020 00:06:38 +0000 (10:06 +1000)
commit1540e39857fdcb15532c5ded097ff95272908f5a
tree7a31359ebf07c0d4ff0a2c047eacd9f87dadc1a9
parent0cf02b0e5dd780d703b70ed39a9add0c62937aad
drm/ttm/nouveau: don't call tt destroy callback on alloc failure.

This is confusing, and from my reading of all the drivers only
nouveau got this right.

Just make the API act under driver control of it's own allocation
failing, and don't call destroy, if the page table fails to
create there is nothing to cleanup here.

(I'm willing to believe I've missed something here, so please
review deeply).

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200728041736.20689-1-airlied@gmail.com
drivers/gpu/drm/nouveau/nouveau_sgdma.c
drivers/gpu/drm/ttm/ttm_tt.c