]> git.baikalelectronics.ru Git - kernel.git/commit
drm/meson: Uninstall IRQ handler
authorJean-Philippe Brucker <jean-philippe.brucker@arm.com>
Fri, 22 Mar 2019 15:26:57 +0000 (15:26 +0000)
committerNeil Armstrong <narmstrong@baylibre.com>
Mon, 25 Mar 2019 10:18:47 +0000 (11:18 +0100)
commit1516216d31e453d1c4ecd43992f6df0730ab88a6
treecb747ddea9c75d7f786ae529b39b1a7bd1239b79
parent01430c305c853e90f3e30ec5fde67b68745678ec
drm/meson: Uninstall IRQ handler

meson_drv_unbind() doesn't unregister the IRQ handler, which can lead to
use-after-free if the IRQ fires after unbind:

[   64.656876] Unable to handle kernel paging request at virtual address ffff000011706dbc
...
[   64.662001] pc : meson_irq+0x18/0x30 [meson_drm]

I'm assuming that a similar problem could happen on the error path of
bind(), so uninstall the IRQ handler there as well.

Fixes: e5a2f708e761 ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190322152657.13752-2-jean-philippe.brucker@arm.com
drivers/gpu/drm/meson/meson_drv.c