]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: spectrum_router: Re-increase scale of IPv6 nexthop groups
authorIdo Schimmel <idosch@mellanox.com>
Sun, 19 Apr 2020 07:01:05 +0000 (10:01 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Apr 2020 18:57:33 +0000 (11:57 -0700)
commit14bea6a709665e1b326968f1d0e4d10d8f7b0928
treec4f4e3881e7409f3ea6450368f5d4e41522da01e
parentdbf96c844a452ca2ee7a4cf3991708d115819672
mlxsw: spectrum_router: Re-increase scale of IPv6 nexthop groups

As explained in commit 23387fe9ce6b ("mlxsw: spectrum_router: Increase
scale of IPv6 nexthop groups"), each nexthop group is hashed by XOR-ing
the interface indexes of all the member nexthop devices.

To avoid many different nexthop groups ending up using the same key, the
above commit started hashing the interface indexes themselves before
they are XOR-ed.

However, in cases in which there are many nexthop groups that all use
the same nexthop device and only differ in the gateway IP, we can still
end up in a situation in which all the groups are using the same key.
This eventually leads to -EBUSY error from rhashtable during insertion.

Improve the situation by also making the gateway IP part of the key.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Alex Veber <alexve@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Tested-by: Alex Veber <alexve@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c