]> git.baikalelectronics.ru Git - kernel.git/commit
mm/migration: fix potential page refcounts leak in migrate_pages
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Apr 2022 06:16:08 +0000 (23:16 -0700)
committerakpm <akpm@linux-foundation.org>
Fri, 29 Apr 2022 06:16:08 +0000 (23:16 -0700)
commit1384d5d94805b00f594e26a75c3bd1e596f005fe
tree4150caea697e7977105623bba4e1d4b0d4a4ff6f
parent28de2e25478f2affce8861c63f6f50cfc507bed3
mm/migration: fix potential page refcounts leak in migrate_pages

In -ENOMEM case, there might be some subpages of fail-to-migrate THPs left
in thp_split_pages list.  We should move them back to migration list so
that they could be put back to the right list by the caller otherwise the
page refcnt will be leaked here.  Also adjust nr_failed and nr_thp_failed
accordingly to make vm events account more accurate.

Link: https://lkml.kernel.org/r/20220318111709.60311-10-linmiaohe@huawei.com
Fixes: ea698cc2b7c0 ("mm: migrate: fix the return value of migrate_pages()")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Cc: Alistair Popple <apopple@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/migrate.c