]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: disable BH in sctp_for_each_endpoint
authorXin Long <lucien.xin@gmail.com>
Sat, 10 Jun 2017 06:48:14 +0000 (14:48 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Jun 2017 20:18:10 +0000 (16:18 -0400)
commit12dac49a3958381e90bf3b9d42c1d06dbe79dc9c
tree7364921671ba8789fec957642ed0835bf8953dfd
parent0818bcba9b80ec83a7f4c41cffbea3de100ec251
sctp: disable BH in sctp_for_each_endpoint

Now sctp holds read_lock when foreach sctp_ep_hashtable without disabling
BH. If CPU schedules to another thread A at this moment, the thread A may
be trying to hold the write_lock with disabling BH.

As BH is disabled and CPU cannot schedule back to the thread holding the
read_lock, while the thread A keeps waiting for the read_lock. A dead
lock would be triggered by this.

This patch is to fix this dead lock by calling read_lock_bh instead to
disable BH when holding the read_lock in sctp_for_each_endpoint.

Fixes: d6325af46309 ("sctp: export some apis or variables for sctp_diag and reuse some for proc")
Reported-by: Xiumei Mu <xmu@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c