]> git.baikalelectronics.ru Git - kernel.git/commit
spi: Use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 7 Jun 2019 18:48:45 +0000 (13:48 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 10 Jun 2019 14:42:09 +0000 (15:42 +0100)
commit122bbca0d0fe619b165ab1dd70f168685498d54d
tree0297f0e09f5208eaf4869ca72f0ffcc3bf1b10bc
parent393864891618ad1946e998ec80681fb1e370b891
spi: Use struct_size() helper

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct spi_replaced_transfers {
...
        struct spi_transfer inserted_transfers[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

insert * sizeof(struct spi_transfer) + sizeof(struct spi_replaced_transfers)

with:

struct_size(rxfer, inserted_transfers, insert)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c