]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate
authorJonathan Liu <net147@gmail.com>
Tue, 9 Jan 2018 02:03:21 +0000 (13:03 +1100)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Thu, 11 Jan 2018 12:25:13 +0000 (13:25 +0100)
commit111f4c3309397370f1fd9579754f06b82055041d
tree8896804504831fcbd831e47344016e929ab61456
parentb0bb222440a5c8273f67dd37946707e6ba6ad832
drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

It is possible that if there is no exact rate match and
"rounded = clk_hw_round_rate(parent, ideal)" gives high enough values
(e.g. if rounded is 2 * ideal) that the condition
"abs(rate - rounded / i) < abs(rate - best_parent / best_div)" is never
met and best_parent is never set. This results in req->rate and
req->best_parent_rate being assigned 0.

To avoid this, we set best_parent to the first calculated rate if it is
unset. The sun4i_tmds_calc_divider function already has a similar check.

Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180109020323.11852-2-net147@gmail.com
drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c