]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: fix force usage in inc_block_group_ro
authorJosef Bacik <josef@toxicpanda.com>
Fri, 17 Jan 2020 14:07:38 +0000 (09:07 -0500)
committerDavid Sterba <dsterba@suse.com>
Fri, 31 Jan 2020 13:01:55 +0000 (14:01 +0100)
commit10ed467d6b718a2cc57c68420259ce34ef8fbc42
tree1509f3939da6c5787fcd31c1e831f505e8cad4bd
parent9bfe63f2e44948bfbcf776d3d26f4d0016482609
btrfs: fix force usage in inc_block_group_ro

For some reason we've translated the do_chunk_alloc that goes into
btrfs_inc_block_group_ro to force in inc_block_group_ro, but these are
two different things.

force for inc_block_group_ro is used when we are forcing the block group
read only no matter what, for example when the underlying chunk is
marked read only.  We need to not do the space check here as this block
group needs to be read only.

btrfs_inc_block_group_ro() has a do_chunk_alloc flag that indicates that
we need to pre-allocate a chunk before marking the block group read
only.  This has nothing to do with forcing, and in fact we _always_ want
to do the space check in this case, so unconditionally pass false for
force in this case.

Then fixup inc_block_group_ro to honor force as it's expected and
documented to do.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/block-group.c