]> git.baikalelectronics.ru Git - kernel.git/commit
rcu: Don't invoke try_invoke_on_locked_down_task() with irqs disabled
authorPaul E. McKenney <paulmck@kernel.org>
Thu, 24 Sep 2020 22:11:55 +0000 (15:11 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Wed, 11 Nov 2020 01:10:38 +0000 (17:10 -0800)
commit10c4b0c51d7c4f6445128dec811407509ce28bec
tree28a9a74e6d8a28099af47e7aa663a12c1e539365
parent68ed2672b8fdb9454c449f573990714135c93adc
rcu: Don't invoke try_invoke_on_locked_down_task() with irqs disabled

The try_invoke_on_locked_down_task() function requires that
interrupts be enabled, but it is called with interrupts disabled from
rcu_print_task_stall(), resulting in an "IRQs not enabled as expected"
diagnostic.  This commit therefore updates rcu_print_task_stall()
to accumulate a list of the first few tasks while holding the current
leaf rcu_node structure's ->lock, then releases that lock and only then
uses try_invoke_on_locked_down_task() to attempt to obtain per-task
detailed information.  Of course, as soon as ->lock is released, the
task might exit, so the get_task_struct() function is used to prevent
the task structure from going away in the meantime.

Link: https://lore.kernel.org/lkml/000000000000903d5805ab908fc4@google.com/
Fixes: ff6039f3b370 ("rcu: Add per-task state to RCU CPU stall warnings")
Reported-by: syzbot+cb3b69ae80afd6535b0e@syzkaller.appspotmail.com
Reported-by: syzbot+f04854e1c5c9e913cc27@syzkaller.appspotmail.com
Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/rcu/tree_stall.h