]> git.baikalelectronics.ru Git - kernel.git/commit
riscv module: remove (NOLOAD)
authorFangrui Song <maskray@google.com>
Tue, 22 Mar 2022 01:26:17 +0000 (18:26 -0700)
committerPalmer Dabbelt <palmer@rivosinc.com>
Tue, 29 Mar 2022 21:31:07 +0000 (14:31 -0700)
commit1000cc761b1ef3b0a547750ff430470c83b9a295
tree771dd9a723bf41feb498b6fb93cf460003e2715b
parentd654a292d912ecbf824dd772a46a7d4d6dfcb50c
riscv module: remove (NOLOAD)

On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
inappropriate for .plt, .got, and .got.plt sections which are always
SHT_PROGBITS.

In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
and (NOLOAD) will be essentially ignored. In ld.lld, since
https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
customize the output section type"), ld.lld will report a `section type
mismatch` error (later changed to a warning). Just remove (NOLOAD) to
fix the warning.

[1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
section should be marked as not loadable" on
https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
outdated for ELF.

Link: https://github.com/ClangBuiltLinux/linux/issues/1597
Fixes: 9dc0b36b2828 ("RISC-V: Add sections of PLT and GOT for kernel module")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Fangrui Song <maskray@google.com>
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/include/asm/module.lds.h