]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "block/mq-deadline: Add cgroup support"
authorTejun Heo <tj@kernel.org>
Wed, 11 Aug 2021 17:41:45 +0000 (07:41 -1000)
committerJens Axboe <axboe@kernel.dk>
Wed, 11 Aug 2021 19:47:26 +0000 (13:47 -0600)
commit0f78399551146bfbed357759e2ad5abb8d39e50a
tree35c04358d12cd454ec16af98ac5c0a7df951cd29
parent11431e26c9c43fa26f6b33ee1a90989f57b86024
Revert "block/mq-deadline: Add cgroup support"

This reverts commit 08a9ad8bf607 ("block/mq-deadline: Add cgroup support")
and a follow-up commit c06bc5a3fb42 ("block/mq-deadline: Remove a
WARN_ON_ONCE() call"). The added cgroup support has the following issues:

* It breaks cgroup interface file format rule by adding custom elements to a
  nested key-value file.

* It registers mq-deadline as a cgroup-aware policy even though all it's
  doing is collecting per-cgroup stats. Even if we need these stats, this
  isn't the right way to add them.

* It hasn't been reviewed from cgroup side.

Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/Kconfig.iosched
block/Makefile
block/mq-deadline-cgroup.c [deleted file]
block/mq-deadline-cgroup.h [deleted file]
block/mq-deadline-main.c [deleted file]
block/mq-deadline.c [new file with mode: 0644]