]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qeth: be drop monitor friendly
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 18 Mar 2019 15:40:56 +0000 (16:40 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Mar 2019 01:34:45 +0000 (18:34 -0700)
commit0f6fe8c6af14ba6b7ce4b220907558e310929a54
tree3473dc041ea1a079657e48800aacaf630209b7f9
parent02e55597808bb67d6bcf96dc7d8231efc1eac2bd
s390/qeth: be drop monitor friendly

As part of the TX completion path, qeth_release_skbs() frees the completed
skbs with __skb_queue_purge(). This ends in kfree_skb(), reporting every
completed skb as dropped.
On the other hand when dropping an skb in .ndo_start_xmit, we end up
calling consume_skb()... where we should be using kfree_skb() so that
drop monitors get notified.

Switch the drop/consume logic around, and also don't accumulate dropped
packets in the tx_errors statistics.

Fixes: e39905eacfca ("s390/qeth: replace open-coded skb_queue_walk()")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core_main.c
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c