]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: omap-dma: Fix memory leak when terminating running transfer
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Fri, 27 Mar 2015 11:35:52 +0000 (13:35 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 30 Mar 2015 17:47:08 +0000 (23:17 +0530)
commit0ed435680550efdb2fb793c2caba51360d07dac2
tree898b6fbafd87b87b6734afc1fa7732902356a799
parente2c60b5239d441e9c34352a551e33a160f3ab2f0
dmaengine: omap-dma: Fix memory leak when terminating running transfer

In omap_dma_start_desc the vdesc->node is removed from the virt-dma
framework managed lists (to be precise from the desc_issued list).
If a terminate_all comes before the transfer finishes the omap_desc will
not be freed up because it is not in any of the lists and we stopped the
DMA channel so the transfer will not going to complete.
There is no special sequence for leaking memory when using cyclic (audio)
transfer: with every start and stop of a cyclic transfer the driver leaks
struct omap_desc worth of memory.

Free up the allocated memory directly in omap_dma_terminate_all() since the
framework will not going to do that for us.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: <stable@vger.kernel.org>
CC: <linux-omap@vger.kernel.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/omap-dma.c