]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Tue, 18 Oct 2022 02:19:20 +0000 (03:19 +0100)
committerWolfram Sang <wsa@kernel.org>
Wed, 19 Oct 2022 19:36:50 +0000 (21:36 +0200)
commit0ecd7c2614f8f1926a80ffb82bedd3473034e1ce
treef9964f2f0b709e761ddf4da304d40f80d9867d74
parent8614e2a855d394d4f47a775292f294ace5661289
i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter

When we compile-in the CCI along with the imx412 driver and run on the RB5
we see that i2c_add_adapter() causes the probe of the imx412 driver to
happen.

This probe tries to perform an i2c xfer() and the xfer() in i2c-qcom-cci.c
fails on pm_runtime_get() because the i2c-qcom-cci.c::probe() function has
not completed to pm_runtime_enable(dev).

Fix this sequence by ensuring pm_runtime_xxx() calls happen prior to adding
the i2c adapter.

Fixes: c76652cf3f0d ("i2c: Add Qualcomm CCI I2C driver")
Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-qcom-cci.c