]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: fix potential use-after-free in ec_bhf_remove
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 18 Jun 2021 13:49:02 +0000 (16:49 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Jun 2021 20:01:17 +0000 (13:01 -0700)
commit0e86f0d4a9cf313aef076616e095447a4eb01463
tree2665950cb2d0dc90397cf0c63063a80ef4d2777e
parentd685d03cbbd3ddf1a5120285a42648256f1f9195
net: ethernet: fix potential use-after-free in ec_bhf_remove

static void ec_bhf_remove(struct pci_dev *dev)
{
...
struct ec_bhf_priv *priv = netdev_priv(net_dev);

unregister_netdev(net_dev);
free_netdev(net_dev);

pci_iounmap(dev, priv->dma_io);
pci_iounmap(dev, priv->io);
...
}

priv is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing priv
pointer. So, fix it by moving free_netdev() after pci_iounmap()
calls.

Fixes: 39ee2f6698c3 ("Driver for Beckhoff CX5020 EtherCAT master module.")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ec_bhf.c