]> git.baikalelectronics.ru Git - kernel.git/commit
[media] bttv/cx25821/cx88/ivtv: use sg_next instead of sg++
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 21 Nov 2014 10:57:12 +0000 (07:57 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 25 Nov 2014 10:12:53 +0000 (08:12 -0200)
commit0e846fd7327cd094827012e5052899b4c1383746
treed3a736a51219e493ed94c3ecc203b36168d887fc
parentbe807db6821ac51f6b1625a0ec01a8c1b3e6e1c1
[media] bttv/cx25821/cx88/ivtv: use sg_next instead of sg++

Never use sg++, always use sg = sg_next(sg). Scatterlist entries can
be combined if the memory is contiguous but sg++ won't know about that.

As far as I can tell cx88 and ivtv are really broken because of this,
and bttv and cx25821 are OK because vb1 doesn't combine scatterlist
entries.

But regardless, sg++ should never be used, only sg_next is safe.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/bt8xx/bttv-risc.c
drivers/media/pci/cx25821/cx25821-core.c
drivers/media/pci/cx88/cx88-core.c
drivers/media/pci/ivtv/ivtv-udma.c