]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: Remove pci_mmap_page_range() wrapper
authorArnd Bergmann <arnd@arndb.de>
Fri, 15 Jul 2022 15:36:16 +0000 (17:36 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 29 Jul 2022 17:08:44 +0000 (12:08 -0500)
commit0e8111d57495bfb4dc55efcc42f2d665fd60c9a1
tree7bc27c2b76e08d19185091591a531e5a3ddea223
parentcf1710d1388cf5bd81996b258399c4907d27006e
PCI: Remove pci_mmap_page_range() wrapper

The ARCH_GENERIC_PCI_MMAP_RESOURCE symbol came up in a recent discussion,
and I noticed that this was left behind by an unfinished cleanup from 2017.

The only architecture that still relies on providing its own
pci_mmap_page_range() helper instead of using the generic
pci_mmap_resource_range() is sparc. Presumably the reasons for this have
not changed, but at least this can be simplified by converting sparc to use
the same interface as the others.

The only difference between the two is the device-specific offset that gets
added to or subtracted from vma->vm_pgoff.

Change the only caller of pci_mmap_page_range() in common code to subtract
this offset and call the modern interface, while adding it back in the
sparc implementation to preserve the existing behavior.

This removes the complexities of the dual interfaces from the common code,
and keeps it all specific to the sparc architecture code. According to
David Miller, the sparc code lets user space poke into the VGA I/O port
registers by mmapping the I/O space of the parent bridge device, which is
something that the generic pci_mmap_resource_range() code apparently does
not.

Link: https://lore.kernel.org/lkml/1519887203.622.3.camel@infradead.org/t/
Link: https://lore.kernel.org/lkml/20220714214657.2402250-3-shorne@gmail.com/
Link: https://lore.kernel.org/r/20220715153617.3393420-1-arnd@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Stafford Horne <shorne@gmail.com>
Documentation/PCI/sysfs-pci.rst
arch/sparc/kernel/pci.c
drivers/pci/mmap.c
drivers/pci/proc.c
include/linux/pci.h