]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "nfsd4: return default lease period"
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 14 Feb 2019 17:33:19 +0000 (12:33 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 14 Feb 2019 17:33:19 +0000 (12:33 -0500)
commit0e2f4975d5e24953750f96db8ea469fce98688e1
treeb44c8f20cb57bfc55d502dc09c3ee829e0baf73f
parent2503bf7de69d23d2eab2c88051ef8b81cee04522
Revert "nfsd4: return default lease period"

This reverts commit 8f80c4d9b00411a670e280254dd4e0c02d76142b.

I forgot that the kernel's default lease period should never be
decreased!

After a kernel upgrade, the kernel has no way of knowing on its own what
the previous lease time was.  Unless userspace tells it otherwise, it
will assume the previous lease period was the same.

So if we decrease this value in a kernel upgrade, we end up enforcing a
grace period that's too short, and clients will fail to reclaim state in
time.  Symptoms may include EIO and log messages like "NFS:
nfs4_reclaim_open_state: Lock reclaim failed!"

There was no real justification for the lease period decrease anyway.

Reported-by: Donald Buczek <buczek@molgen.mpg.de>
Fixes: 8f80c4d9b004 "nfsd4: return default lease period"
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfsctl.c