]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: pci: lx6464es: fix a debug loop
authorDan Carpenter <error27@gmail.com>
Tue, 31 Jan 2023 10:02:13 +0000 (13:02 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 18:11:49 +0000 (19:11 +0100)
commit0e0715f19731945711f92b82dc22beea126be3a0
tree0ef8bf23bd282bde66eac2ffed582a7bb4f6acad
parent67699abbe833b7b7a7c30ad0352aaafca335107d
ALSA: pci: lx6464es: fix a debug loop

[ Upstream commit 05698513844a6f2abc69e78a487e7bccb0154f3c ]

This loop accidentally reuses the "i" iterator for both the inside and
the outside loop.  The value of MAX_STREAM_BUFFER is 5.  I believe that
chip->rmh.stat_len is in the 2-12 range.  If the value of .stat_len is
4 or more then it will loop exactly one time, but if it's less then it
is a forever loop.

It looks like it was supposed to combined into one loop where
conditions are checked.

Fixes: ecec7f5b7c31 ("ALSA: lx_core: Remove useless #if 0 .. #endif")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y9jnJTis/mRFJAQp@kili
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/lx6464es/lx_core.c