]> git.baikalelectronics.ru Git - kernel.git/commit
net_sched: get rid of unnecessary dev_qdisc_reset()
authorCong Wang <xiyou.wangcong@gmail.com>
Wed, 27 May 2020 04:35:27 +0000 (21:35 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 27 May 2020 22:05:49 +0000 (15:05 -0700)
commit0ddfb76b5682570a7b64977bfc00e931b2198e2f
tree05d0ac479515a9cf925dcefa78718641e8165d5b
parent6ee20cd616cc4016fc684164d2a9bdce1bbd3595
net_sched: get rid of unnecessary dev_qdisc_reset()

Resetting old qdisc on dev_queue->qdisc_sleeping in
dev_qdisc_reset() is redundant, because this qdisc,
even if not same with dev_queue->qdisc, is reset via
qdisc_put() right after calling dev_graft_qdisc() when
hitting refcnt 0.

This is very easy to observe with qdisc_reset() tracepoint
and stack traces.

Reported-by: Václav Zindulka <vaclav.zindulka@tlapnet.cz>
Tested-by: Václav Zindulka <vaclav.zindulka@tlapnet.cz>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c