]> git.baikalelectronics.ru Git - kernel.git/commit
[SCSI] zfcp: restore refcount check on port_remove
authorSteffen Maier <maier@linux.vnet.ibm.com>
Tue, 4 Sep 2012 13:23:34 +0000 (15:23 +0200)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 24 Sep 2012 08:11:02 +0000 (12:11 +0400)
commit0db5d958c2d7fdd51d4122c568425571cde3ec28
tree208966f18e89775d68e82092c1ff648206fbd688
parent43bc9b9a6f1f87a108a99f21da2811851a476889
[SCSI] zfcp: restore refcount check on port_remove

Upstream commit 7d3d929fc6e96dacb268fa936c64051c44799e12
"[SCSI] zfcp: Replace local reference counting with common kref"
accidentally dropped a reference count check before tearing down
zfcp_ports that are potentially in use by zfcp_units.
Even remote ports in use can be removed causing
unreachable garbage objects zfcp_ports with zfcp_units.
Thus units won't come back even after a manual port_rescan.
The kref of zfcp_port->dev.kobj is already used by the driver core.
We cannot re-use it to track the number of zfcp_units.
Re-introduce our own counter for units per port
and check on port_remove.

Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.33+
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/s390/scsi/zfcp_aux.c
drivers/s390/scsi/zfcp_def.h
drivers/s390/scsi/zfcp_ext.h
drivers/s390/scsi/zfcp_sysfs.c
drivers/s390/scsi/zfcp_unit.c