]> git.baikalelectronics.ru Git - kernel.git/commit
USB: Fix off by one in type-specific length check of BOS SSP capability
authorMathias Nyman <mathias.nyman@linux.intel.com>
Tue, 19 Dec 2017 09:14:42 +0000 (11:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Dec 2017 10:40:54 +0000 (11:40 +0100)
commit0d890ef430dbc813864e89ee9837d892962a51f8
treeadbfc9dfdec85e35427fd85d5c4b10eabc09d47d
parenta227bcc49a7854021331f4586d938991aeafb389
USB: Fix off by one in type-specific length check of BOS SSP capability

USB 3.1 devices are not detected as 3.1 capable since 4.15-rc3 due to a
off by one in commit 1d0ac9b3dafc ("USB: core: Add type-specific length
check of BOS descriptors")

It uses USB_DT_USB_SSP_CAP_SIZE() to get SSP capability size which takes
the zero based SSAC as argument, not the actual count of sublink speed
attributes.

USB3 spec 9.6.2.5 says "The number of Sublink Speed Attributes = SSAC + 1."

The type-specific length check patch was added to stable and needs to be
fixed there as well

Fixes: 1d0ac9b3dafc ("USB: core: Add type-specific length check of BOS descriptors")
Cc: linux-stable <stable@vger.kernel.org>
CC: Masakazu Mokuno <masakazu.mokuno@gmail.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/config.c