]> git.baikalelectronics.ru Git - kernel.git/commit
kdb: Fix handling of kallsyms_symbol_next() return value
authorDaniel Thompson <daniel.thompson@linaro.org>
Mon, 2 Mar 2015 14:13:36 +0000 (14:13 +0000)
committerJason Wessel <jason.wessel@windriver.com>
Wed, 6 Dec 2017 22:12:43 +0000 (16:12 -0600)
commit0d271cb523375ef001d061c4a3191cae6e3d2afa
tree80a6e4faf56936d6524340593ed7d33fd4d4bdb5
parent7192a68628efdf3b4e0b57470a4e8cadeb69915d
kdb: Fix handling of kallsyms_symbol_next() return value

kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.

This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
kernel/debug/kdb/kdb_io.c