]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: microchip: Added the condition for scheduling ksz_mib_read_work
authorArun Ramadoss <arun.ramadoss@microchip.com>
Mon, 11 Oct 2021 15:48:08 +0000 (21:18 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Oct 2021 10:35:53 +0000 (11:35 +0100)
commit0cf0c5b1e86a410785c4207090d8a0c545fe30c9
treee67de351a71dd3f823671bb89777399759b7a6f9
parent5c4a78deca714d362a955c96bc83eebafed7302c
net: dsa: microchip: Added the condition for scheduling ksz_mib_read_work

When the ksz module is installed and removed using rmmod, kernel crashes
with null pointer dereferrence error. During rmmod, ksz_switch_remove
function tries to cancel the mib_read_workqueue using
cancel_delayed_work_sync routine and unregister switch from dsa.

During dsa_unregister_switch it calls ksz_mac_link_down, which in turn
reschedules the workqueue since mib_interval is non-zero.
Due to which queue executed after mib_interval and it tries to access
dp->slave. But the slave is unregistered in the ksz_switch_remove
function. Hence kernel crashes.

To avoid this crash, before canceling the workqueue, resetted the
mib_interval to 0.

v1 -> v2:
-Removed the if condition in ksz_mib_read_work

Fixes: 13a1fc82a338 ("net: dsa: microchip: use delayed_work instead of timer + work")
Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/microchip/ksz_common.c