]> git.baikalelectronics.ru Git - kernel.git/commit
ext2: fix fs corruption when trying to remove a non-empty directory with IO error
authorYe Bin <yebin10@huawei.com>
Wed, 15 Jun 2022 09:00:10 +0000 (17:00 +0800)
committerJan Kara <jack@suse.cz>
Thu, 16 Jun 2022 08:55:45 +0000 (10:55 +0200)
commit0cd706ad63144c80c1d776686b2677b1bc24ec08
tree356b9b9500d65aed818faeb3bb39a1af454c610c
parentb52d5a6d90c5addd271912240e89be49abd74565
ext2: fix fs corruption when trying to remove a non-empty directory with IO error

We got issue as follows:
[home]# mount  /dev/sdd  test
[home]# cd test
[test]# ls
dir1  lost+found
[test]# rmdir  dir1
ext2_empty_dir: inject fault
[test]# ls
lost+found
[test]# cd ..
[home]# umount test
[home]# fsck.ext2 -fn  /dev/sdd
e2fsck 1.42.9 (28-Dec-2013)
Pass 1: Checking inodes, blocks, and sizes
Inode 4065, i_size is 0, should be 1024.  Fix? no

Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Unconnected directory inode 4065 (/???)
Connect to /lost+found? no

'..' in ... (4065) is / (2), should be <The NULL inode> (0).
Fix? no

Pass 4: Checking reference counts
Inode 2 ref count is 3, should be 4.  Fix? no

Inode 4065 ref count is 2, should be 3.  Fix? no

Pass 5: Checking group summary information

/dev/sdd: ********** WARNING: Filesystem still has errors **********

/dev/sdd: 14/128016 files (0.0% non-contiguous), 18477/512000 blocks

Reason is same with commit 5b3ef73dca9f. We can't assume directory
is empty when read directory entry failed.

Link: https://lore.kernel.org/r/20220615090010.1544152-1-yebin10@huawei.com
Signed-off-by: Ye Bin <yebin10@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/dir.c