]> git.baikalelectronics.ru Git - kernel.git/commit
e1000e: remove use of IP payload checksum
authorBruce Allan <bruce.w.allan@intel.com>
Sat, 30 Jun 2012 20:02:42 +0000 (20:02 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Jul 2012 07:25:32 +0000 (00:25 -0700)
commit0cb1a56c221d4e9e99b2edde8066c79ecb6b80fe
treed6285c0a9ab06241aa3df9a1bd60f49cbef4ac0c
parentdf190b17f8cb0806621780fd521ab36532bddeb3
e1000e: remove use of IP payload checksum

Currently only used when packet split mode is enabled with jumbo frames,
IP payload checksum (for fragmented UDP packets) is mutually exclusive with
receive hashing offload since the hardware uses the same space in the
receive descriptor for the hardware-provided packet checksum and the RSS
hash, respectively.  Users currently must disable jumbos when receive
hashing offload is enabled, or vice versa, because of this incompatibility.
Since testing has shown that IP payload checksum does not provide any real
benefit, just remove it so that there is no longer a choice between jumbos
or receive hashing offload but not both as done in other Intel GbE drivers
(e.g. e1000, igb).

Also, add a missing check for IP checksum error reported by the hardware;
let the stack verify the checksum when this happens.

CC: stable <stable@vger.kernel.org> [3.4]
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/e1000e/defines.h
drivers/net/ethernet/intel/e1000e/netdev.c