]> git.baikalelectronics.ru Git - kernel.git/commit
drbd: fix decoding of bitmap vli rle for device sizes > 64 TB
authorLars Ellenberg <lars.ellenberg@linbit.com>
Wed, 23 Oct 2013 08:59:18 +0000 (10:59 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 8 Nov 2013 16:10:28 +0000 (09:10 -0700)
commit0c6f45b631c86456f30c4ab123fe475ef70dbd93
treeb2d883aa031c9ed894a0dc797400e312226e8251
parent009dfe2f4e234e1b449b91b55e69423c29583a8a
drbd: fix decoding of bitmap vli rle for device sizes > 64 TB

Symptoms: disconnect after bitmap exchange due to
bitmap overflow (e:49731075554) while decoding bm RLE packet

In the decoding step of the variable length integer run length encoding
there was potentially an uncatched bitshift by wordsize (variable >> 64).

The result of which is "undefined" :(
(only "sometimes" the result is the desired 0)

Fix: don't do any bit shift magic for shift == 64, just assign.

Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_receiver.c