]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: do not use RT_TOS for IPv6 flowlabel
authorMatthias May <matthias.may@westermo.com>
Fri, 5 Aug 2022 19:19:06 +0000 (21:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Aug 2022 05:19:21 +0000 (22:19 -0700)
commit0c5ffa103e477c6cd1651a33aba8589a622b5ceb
tree0ce31b098bb79f7f08e82de92de6d6ca25c1e3f4
parentd97f9f70f79951c5c1dfd373921c2d87f035e5a5
ipv6: do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 36553515916a ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.")
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Matthias May <matthias.may@westermo.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/ip6_output.c