]> git.baikalelectronics.ru Git - kernel.git/commit
usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fri, 30 Jan 2015 06:58:23 +0000 (15:58 +0900)
committerFelipe Balbi <balbi@ti.com>
Fri, 30 Jan 2015 16:35:37 +0000 (10:35 -0600)
commit0c3af29b3f35872d786cdf90f577626bf1a82b46
tree45e5c58be6ab7fe6965e700fae0a556b33e30f9d
parent13ee73e91decd2b0107287f7cb29ccad0511495c
usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

This patch fixes an issue that the following commit causes NULL
pointer dereference in dma_release_channel().
 "usb: renesas_usbhs: add support for requesting DT DMA"
 (commit id f3f4972ea6e6d8c3635281a875378d83a2bcfbc2)

The usbhsf_dma_init_dt() should set fifo->{t,r}x_chan to NULL if
dma_request_slave_channel_reason() returns IS_ERR value.
Otherwise, usbhsf_dma_quit() will call dma_release_channel(), and then
NULL pointer dereference happens.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Simon Horman <horms+renesas@verge.net.au>
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/fifo.c