]> git.baikalelectronics.ru Git - kernel.git/commit
kconfig: Update config changed flag before calling callback
authorJurica Vukadin <jura@vukad.in>
Tue, 7 Mar 2023 19:40:39 +0000 (20:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2023 12:33:52 +0000 (13:33 +0100)
commit0bfb01046f10e87f169718a45054f5b7b7be7b6c
tree7006bca1caef096a1d227668cdd5d9aed3a419b6
parent2b8d4b9b9af7ec1d3a32a9a39aa06fa8f6e740bc
kconfig: Update config changed flag before calling callback

[ Upstream commit 86c3e3bacef8ea8852914a05089b98613fe9e8d3 ]

Prior to commit 8d17b7d0d7fa ("kconfig: change sym_change_count to a
boolean flag"), the conf_updated flag was set to the new value *before*
calling the callback. xconfig's save action depends on this behaviour,
because xconfig calls conf_get_changed() directly from the callback and
now sees the old value, thus never enabling the save button or the
shortcut.

Restore the previous behaviour.

Fixes: 8d17b7d0d7fa ("kconfig: change sym_change_count to a boolean flag")
Signed-off-by: Jurica Vukadin <jura@vukad.in>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
scripts/kconfig/confdata.c