]> git.baikalelectronics.ru Git - kernel.git/commit
tracing: Truncated output is better than nothing
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 27 Nov 2014 15:57:52 +0000 (18:57 +0300)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 3 Dec 2014 22:10:14 +0000 (17:10 -0500)
commit0b206dd59c57969a77f9d3a0acffe0d354c88fae
tree748ba84148b99c750900206d90e5969e505726b6
parent7459b32aaf64b67d8d0f17ea3691a10c9d9d76d2
tracing: Truncated output is better than nothing

The initial reason for this patch is that I noticed that:

if (len > TRACE_BUF_SIZE)

is off by one.  In this code, if len == TRACE_BUF_SIZE, then it means we
have truncated the last character off the output string.  If we truncate
two or more characters then we exit without printing.

After some discussion, we decided that printing truncated data is better
than not printing at all so we should just use vscnprintf() and remove
the test entirely.  Also I have updated memcpy() to copy the NUL char
instead of setting the NUL in a separate step.

Link: http://lkml.kernel.org/r/20141127155752.GA21914@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace.c